Fedoraware / Fedoraware

Free and open-source training software for Team Fortress 2
Do What The F*ck You Want To Public License
111 stars 98 forks source link

Remove forced angle from teleporting #302

Closed SeasonalFerret closed 2 years ago

SeasonalFerret commented 2 years ago

https://github.com/tf2cheater2013/Fedoraware/commit/40b94aed2c5b2cb164715c91201285439bc20c5d#commitcomment-74043578

When used in combination with Camera: Teleporter and RemoveScreenEffects, you could use this in order to kill anybody camping a teleporter. Or at least instantly start walking the direction you want instead of running into a wall.

https://user-images.githubusercontent.com/17802843/169581484-91c48648-3eec-4695-9755-ea26fd0e2c71.mp4

SeasonalFerret commented 2 years ago

This is actually turning out to be something very interesting.

SeasonalFerret commented 2 years ago

Uh not really... There is angles and placement of the teleport

I don't understand what you are saying. Someone implementing a feature that would close this issue would solve angles. Placement is out of our hands. The placement really isn't a big deal. If the placement is bad, the exit teleporter will just get destroyed. So an exit teleporter that still exists therefore has good placement. The problem is the angles. Sometimes the angle of the teleporter points you straight into a wall- Or, in this case, literally anywhere other than the enemy. This suggestion fixes this problem by allowing you to force your own angle.

lnx00 commented 2 years ago

I'll have a look how the game is forcing the viewangle.

elf-XNSR commented 2 years ago

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143

lnx00 commented 2 years ago

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143

Saw that too. No clue how we could prevent it though. Teleport will set the angle through the m_angRotation prop. So we would need to ignore/block it on the client side...

JustStayingPositive commented 2 years ago

Is it not possible to paste it from ncc

On Thu, May 26, 2022, 11:15 AM lnx00 < @.***> wrote:

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143 Saw that too. No clue how we could prevent it though. Teleport w DuckDuckGo removed 1 tracker. More →

https://duckduckgo.com/email/report#RFVDSzI.G0gBoCwK7Abn_oxEmCbKr4ilyNYeiNtSXyjH0DRagkHhXMH032ix6ETf4DnyAy6584t1J3ow_f7v-36qRW3NA03SCLMSDi29YSmOW0Gz9UtDtalT1xDVTu63BF0Y2QhaBQIyReCQntWD68RENwC7PL_08-lUuMryEH18J-0SABt8QlCtBnub1-EQ_COpnTMssh4J7ya35eBeWPO_d4BzRQzsQFL_XR2D4J9-vgmMOf3H-jBlxnuDF0vpdY9niquVCHi5fkFOo57MByloVoKlJU5HZfD9Dw

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143

Saw that too. No clue how we could prevent it though. Teleport will set the angle through the m_angRotation prop. So we would need to ignore it on the client side...

— Reply to this email directly, view it on GitHub https://github.com/tf2cheater2013/Fedoraware/issues/302#issuecomment-1138745711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY623Q5IUJXSDRIDU32GZRDVL6PRBANCNFSM5WQDWHBQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

elf-XNSR commented 2 years ago

Is it not possible to paste it from ncc

On Thu, May 26, 2022, 11:15 AM lnx00 < @.***> wrote:

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143 Saw that too. No clue how we could prevent it though. Teleport w DuckDuckGo removed 1 tracker. More →

https://duckduckgo.com/email/report#RFVDSzI.G0gBoCwK7Abn_oxEmCbKr4ilyNYeiNtSXyjH0DRagkHhXMH032ix6ETf4DnyAy6584t1J3ow_f7v-36qRW3NA03SCLMSDi29YSmOW0Gz9UtDtalT1xDVTu63BF0Y2QhaBQIyReCQntWD68RENwC7PL_08-lUuMryEH18J-0SABt8QlCtBnub1-EQ_COpnTMssh4J7ya35eBeWPO_d4BzRQzsQFL_XR2D4J9-vgmMOf3H-jBlxnuDF0vpdY9niquVCHi5fkFOo57MByloVoKlJU5HZfD9Dw

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143

Saw that too. No clue how we could prevent it though. Teleport will set the angle through the m_angRotation prop. So we would need to ignore it on the client side...

— Reply to this email directly, view it on GitHub https://github.com/tf2cheater2013/Fedoraware/issues/302#issuecomment-1138745711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY623Q5IUJXSDRIDU32GZRDVL6PRBANCNFSM5WQDWHBQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

does nc even have it?

JustStayingPositive commented 2 years ago

Yeah. I don't remember what it's called but it doesn't let (re)spawning or teleporters change your angle

On Thu, May 26, 2022, 4:13 PM Baan < @.***> wrote:

Is it not possible to paste it from ncc On Thu, May 26, 2022, 11:15 AM lnx00 < @ .**> wrote: https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/t DuckDuckGo* removed 1 tracker. More →

https://duckduckgo.com/email/report#RFVDSzI.G0gBoCwK7Abn_oxEmCbKr4ilyNYeiNtSXyjH0DRagkHhXMH032ix6ETf4DnyA67Oi8h1J3ow_f7v-36qRW3NA03SCLMSDi29YSmOW0Gz9UtDtalT1xDVTu63BF0Y2QhaBQIyReCQntWD68RENwC7PL_08-lUuMryEH18J-0SAOtj_knpUzmnvw59WOHvtVDMk-oR7yq2YeBeWNLa28MxAwamI6FWk0cjuOJim8CQ4jrG-SES3hu8kHMruz-dbemh2cv1C3Ia9ag_SEGzEiwtcToqg-9_AA

Is it not possible to paste it from ncc

On Thu, May 26, 2022, 11:15 AM lnx00 < @.***> wrote:

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143 Saw that too. No clue how we could prevent it though. Teleport w DuckDuckGo removed 1 tracker. More →

https://duckduckgo.com/email/report#RFVDSzI.G0gBoCwK7Abn_oxEmCbKr4ilyNYeiNtSXyjH0DRagkHhXMH032ix6ETf4DnyAy6584t1J3ow_f7v-36qRW3NA03SCLMSDi29YSmOW0Gz9UtDtalT1xDVTu63BF0Y2QhaBQIyReCQntWD68RENwC7PL_08-lUuMryEH18J-0SABt8QlCtBnub1-EQ_COpnTMssh4J7ya35eBeWPO_d4BzRQzsQFL_XR2D4J9-vgmMOf3H-jBlxnuDF0vpdY9niquVCHi5fkFOo57MByloVoKlJU5HZfD9Dw

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143

Saw that too. No clue how we could prevent it though. Teleport will set the angle through the m_angRotation prop. So we would need to ignore it on the client side...

— Reply to this email directly, view it on GitHub

302 (comment)

https://github.com/tf2cheater2013/Fedoraware/issues/302#issuecomment-1138745711 , or unsubscribe

https://github.com/notifications/unsubscribe-auth/AY623Q5IUJXSDRIDU32GZRDVL6PRBANCNFSM5WQDWHBQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

does nc even have it?

— Reply to this email directly, view it on GitHub https://github.com/tf2cheater2013/Fedoraware/issues/302#issuecomment-1139062947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY623Q2SRUHTNQANIGZIENDVL7SQPANCNFSM5WQDWHBQ . You are receiving this because you commented.Message ID: @.***>

ghost commented 2 years ago

https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/tf/tf_obj_teleporter.cpp#L1143

Saw that too. No clue how we could prevent it though. Teleport will set the angle through the m_angRotation prop. So we would need to ignore/block it on the client side...

If u look at the https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/game/server/baseentity.cpp#L4434, you see it only does SnapEyeAngles it if it's it's a player,

void CBasePlayer::SnapEyeAngles( const QAngle &viewAngles )
{
    pl.v_angle = viewAngles;
    pl.fixangle = FIXANGLE_ABSOLUTE;
} 

sets CPlayerState::fixangle and I think it is only used to set the player's viewangles in https://github.com/xxmyn/TeamFortress2/blob/1b81dded673d49adebf4d0958e52236ecc28a956/tf2_src/engine/servermsghandler.cpp#L669, so you can probably do something to stop that from running

elf-XNSR commented 2 years ago

game event "base_player_teleported" occurs when you teleport no matter what ping, listen for the event and when it happens, hold your angles at whatever they were before?

elf-XNSR commented 2 years ago

Added