search

Feel-ix-343 / markdown-oxide

Robust, Minimalist, Unbundled PKM for your favorite text-editor through the LSP
https://oxide.md
GNU General Public License v3.0
925 stars 15 forks source link

Implement filename extension in link completion #114

Closed RyanGreenup closed 4 months ago

RyanGreenup commented 4 months ago

These changes add two options to the config file:

These default to false in order to preserve past behavior. When set to true completions will include the file extension, this is needed for compatibility with other software:

This seeks to close #113.

Please let me know if there are any specific changes you would like made.

Feel-ix-343 commented 4 months ago

Also, do you have any feedback about the completion code? I am doing a refactor to simplify it right now.

Feel-ix-343 commented 4 months ago

🔥

RyanGreenup commented 4 months ago

Also, do you have any feedback about the completion code? I am doing a refactor to simplify it right now.

Nothing glaring, but I'll have a look through and let you know thoughts that come to me. I'm a data scientist by trade so your Rust is probably a lot better than mine, I'm keen on getting better with it though.

Where are you guys chatting, Element / Discord? Keep me in the loop, I love this project and would love to jump in where I can.

Feel-ix-343 commented 4 months ago

Thank you for the kind words! Sounds good.

For now the discussion is on here. A few people use the discussions page to post feedback and ideas. Feel free to open issues too.

I don't think I'd start a discord yet, but it could be useful for the future. What do you think!

RyanGreenup commented 4 months ago

Sounds great, I'll keep an eye on this project and stay around. You've done an excellent job here, good work.

Feel-ix-343 commented 4 months ago

Ahh thank you!

I look forward to working with you in the future