search

Feel-ix-343 / markdown-oxide

PKM for the LSP
https://oxide.md
Apache License 2.0
1.03k stars 17 forks source link

Recognize markdown reference link in form of link text with spaces #145

Closed clobrano closed 2 months ago

clobrano commented 4 months ago

Disclaimer: I am not entirely sure this is up to markdown-oxide, so excuse me in advance if not.

I noticed that markdown reference links in form of link text (an example below) are recognized only if there are no spaces, however I think spaces should be supported (most markdown renderers do support them, for example on GitLab)

example

1. [reference-link-without-spaces]
2. [reference link with spaces]

then, somewhere in the page you also have
[reference-link-without-spaces]: https://somewhere.com
[reference link with spaces]: https://somewhereelse.com

The first link is recognized, and I can use for example nmap('K', vim.lsp.buf.hover, 'Hover Documentation') to show the floating window with information. The second link is not recognized instead.

Feel-ix-343 commented 4 months ago

Hey! Thank you for reporting

Feel-ix-343 commented 3 months ago

I am making a new parser for v1 that is much more align to typical markdown. This feature will be part of that!

Feel-ix-343 commented 2 months ago

as this is planned v1 => not a current issue; closing

Feel-ix-343 commented 2 months ago

if I forget to implement in v1, please reopen (if I don't!)