search

Feel-ix-343 / markdown-oxide

PKM for the LSP
https://oxide.md
Apache License 2.0
1.03k stars 17 forks source link

Rename doesn't work #176

Closed Kyren223 closed 2 months ago

Kyren223 commented 2 months ago

Renaming seems to only rename the links to the current file but doesn't rename the actual file on disk.

Also renaming is very unintuitive in my opinion as whatever is under the cursor gets suggested as the name and it doesn't really make sense that the current file is the one being renamed.

A better renaming system: When the cursor is on the file part of a link, ex: [[My|File#someHeader]] (| is cursor), it should rename the file MyFile, including the actual file on disk and any other links referencing it. When it's on the header such as [[MyFile#som|eHeader]] it should rename that file header, as if you were standing on the actual header and renaming it.

Bonus: Add detection for external renaming (from oil.nvim, netrw etc), so when someone renames the file it will also update the links. Oil.nvim is supposed to already support notifying LSPs about rename/file moving/deletion etc So it will most likely just involve adding support for that on the server.

Really good work! I just need renaming to work properly to cover my needs.

Feel-ix-343 commented 2 months ago

Hey!

Yea I think this is the best approach.

I have stopped working on the current version of oxide, and am now focusing all of my developments on v1. I will add this to the list of planned fixes for v1.

Kyren223 commented 2 months ago

Alright thanks! any estimate for when v1 will be released? even a rough one like if it's days/weeks/months/quarters/years etc

Feel-ix-343 commented 2 months ago

hmmm well I just started a full-time job and I only work on this on the weekends...

perhaps 1-2.5 months (depending on how quickly the vector database comes along)

search will be getting 10x better FYI -- already in my testing it has significantly improved

and for context, I now work for a web-scale vector database company https://exa.ai