search

Feel-ix-343 / markdown-oxide

Editor Agnostic PKM: you bring the text editor and we bring the PKM - inspired by and compatible with Obsidian
GNU General Public License v3.0
682 stars 10 forks source link

Gif -> mp4 for the feature previews #81

Open Feel-ix-343 opened 1 month ago

Feel-ix-343 commented 1 month ago

https://www.reddit.com/r/logseq/comments/1cexbmq/comment/l1p0g1k/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

Faster load times

ThatSealgair commented 1 month ago

I am happy to implement this. Can I be assigned to this task?

ThatSealgair commented 1 month ago

So I looked into this. Unfortunately, what I gathered from this thread is that while technically possible, it may not be legal to implement. Another video format that could be used is .webm which would depend on client support to work.

Feel-ix-343 commented 1 month ago

:fearful:

I didn't know that.

Any format will work; it just needs to be preview-able on the README

Thank you so much for helping!

ThatSealgair commented 1 month ago

I misread the issue. I thought it was an add-on to this LSP. I'll check to see if a .webm works, if not, I'll try to fix the existing gifs to reduce file-size and loading times.

Feel-ix-343 commented 1 month ago

Oh in that case, we could probably use mp4 on the readme, no?

This is better as viewers could pause the previews and they should affect the page load.

Would webm be better?

ThatSealgair commented 1 month ago

I should be able to get MP4 videos to work for this project's README. I'll try to get it done by tomorrow night.

Feel-ix-343 commented 1 month ago

Amazing! Thank you

Feel-ix-343 commented 1 month ago

Hey let me know if you need any help with this!