[Core] [Spell] [Object] [Warlock] Ritual of Summoning issues

[Warlockbugs]

Class: Warlock Spell id: 698 Spell title: Ritual of Summoning More info (2008 data): http://www.wowwiki.com/Ritual_of_Summoning?oldid=1585473

Issues (as of 25th October 2012):

• The reactive target conditions for the spell are not present - the player can start casting this spell without any selected target, with enemy selected, npc selected, and non-group players. This spell's acceptable targets should be limited to: Party members, Raid Members, Battleground group members. The core must return "Invalid target" immediately on attempts to create the summoning portal for other targets. It allows currently to create the portal for any target and checks for conditions AFTER summon effect called by the portal. It wastes soul shards and just isn't the blizzlike way to handle this spell.
• Accepting summon invitation ignores requirements for entering the instance (only the check for the number of players inside is present). Its a widely used exploit now. The summon must maintain the minimum level and specific attune requirements (heroic keys, completed quests, etc). Related report: #1113 (Must be fixed already)
• The deffered handling (its related to threading, probably) of the summon effect is wrong. It tries to summon the current target of the warlock (when summon function is really processed by the core), not the target the summon was really casted for (some moments ago). It results in sending summon invitation to the wrong target VERY OFTEN and even conflicts with some client addons with shady internal target change (Recount for example - it becomes nearly impossible to summon the right person when recount is enabled, as targeting goes nuts). It doesn't allow to cast the spell on mouseover and macro'ed targets too. This is just totally messed up. The core must process some specific structure with remembered guid of the target the spell was initially casted on. These threading problems may also result in widely noticed "non-acceptable" summon invitations issues.
• The portal object "Summoning Portal" (object id: 36727) summoned by the triggered spell "Ritual of Summoning" (Spell id: 46546) counts group members' right-clicks now. It's not the blizzlike way to handle it. The portal must cause group members to channel the assistance spell "Ritual of Summoning" (Spell id: ? Maybe its 32929, but i am unsure), which applies specififc assistance dummy aura with portal guid data (or whatever helps to identify which summon the player is assisting) on the chanelling player. The object script should periodically check (~3 seconds) for the count of these auras on group members (and allow only two players to channel it on right-click at the same time, this is also an instant check for the count of asisstance auras applied), not clicks. The same goes for using Meeting stones and other group-assisted spells.
• Summon invitation should teleport the target to the portal's xyz, not the warlock's coordintes (as it does now). Watch the video below for the proof.

Video attached:

• http://www.youtube.com/watch?v=0_QdNed2QU4 - First seconds show the way it looks like on retail. A prank is included. :)

[xmontex]

"Summon invitation should teleport the target to the portal's xyz, not the warlock's coordintes (as it does now). Watch the video below for the proof." it should... But probably wont happen since it would allow you to summon to the other side of closed doors ;)

[Warlockbugs]

Bump. Updated the list with fix for attunements.

[joKeri]

Summoning still bugs by targetting someone other than the intended target.

[Triokon]

I can confirm the bug report.

I can add the following info:

• Another addon that causes severe problems with the target system when using "Ritual of Summoning" is DiamondThreatMeter.
• I do not know if this is helpful, but the time until someone accepts a summon invitation seems to be related with the bug that causes summon attempts to fail. If a player is in Ironforge, summon invitations take a lot longer to pop up at players because of a problem related to https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/1928 . Due to that bug, summon attempts at players who are in Ironforge, fail most of the time. Therefore, time between summon attempt and accepting the summon seems to be an essential factor.