"on spellcast" procs activate from wrong sources(eg. campfire)

[Fleischi]

"on spellcast" procs can activate from events that clearly should not trigger them.

The most notable(read: abused) examples are probably Insightful Earthstorm Diamond and Darkmoon Card: Blue Dragon proccing from a Basic Campfire whenever the campfire buff is applied/refreshed. If this was correct it would have been common knowledge back then, but I could not find any source stating that an item would proc when you simply gain or refresh a buff for example.

---

List of events that should not be considered a spellcast:

• When your own Basic Campfire applys/refreshs the Cozy Fire buff on you or anybody else near your fire. Only your own fire can cause this.
• When you are a priest and your Prayer of Mending heals somebody. Only the initial application of the buff should be considered a spellcast and proc something, not the resulting heals.
• Something that happens when you log in. from warlockbugs: LOGINEFFECT.

With further investigation we might find more similar issues.

Reproduction Guide: -Create character with activated IED meta (id: 25901) -Put the character into group with one or more other nearby characters -Set a campfire -See that each application of the campfire buff to the other characters has a chance to proc the meta gem

As stated before there are other sources but I guess this one the easiest to reproduce.

[Warlockbugs]

The third spell is called "Login Effect" which is hidden from the spellbook and is casted by the clients themselves.

[devidao]

need reproduction guide

[Fleischi]

Reproduction Guide: -Create character with activated IED meta (id: 25901) -Put the character into group with one or more other nearby characters -Set a campfire -See that each application of the campfire buff to the other characters has a chance to proc the meta gem

As stated before there are other sources but I guess this one the easiest to reproduce.

[Fleischi]

bump

from the other issue:

The real fix would be to only enable "on spellcast" procs on player spells (the good stuff you see when you hit P) instead of all the item effects and what not that are considered spells internally.

Instead of using a camp fire for reproduction you can also use lots of usable (quest) items, enchanting essences and god knows how many other things to trigger. And they trigger the the meta gem proc aswell as the darkmoon card. That is why I assume that it is a general problem with the "on spellcast" mechanic.

Feel free to ask for more details. We can provide everything short of a complete fix.

[devidao]

all spells which have 'positive spell cast' trigger flag also have chance to be triggered by any buff or even spell without any aura (like login effect which is defined as positive spell) , the easiest way to fix it is 'positive spell cast' trigger flag describing as only healing spells, but i am not sure

[Fleischi]

It would have to work for everything from your spellbook, all player cast spells, not only healing ones. IOW more or less all the spells you learn when you ".learn all_myclass" (or something similar. dont remember exact command)

The meta gem for example is also a viable option for shadow priests. You'd lock them out by making this a healing spell thing. There are probably more examples of this. That is just the first thing that came to mind.

I dont know if there is already a fitting flag for this but obviously there should be one for "this is the kind of spell a player sees in his spellbook and actively casts and not some intermediary/helper/whatever spell". Not sure what I'd name it. "player cast spell" or "system cast spell" for the opposite would sound roughly fitting as flag names to describe what should and what should not trigger this kind of effect.