search

FeenixServerProject / Archangel_2.4.3_Bugtracker

This is the official Issue tracker for the Archangel 2.4.3 realm https://www.wow-one.com
78 stars 74 forks source link

Seal of Command and Seal of Blood receive full holy damage bonus from Judgement of the Crusader #3688

Closed mondegoftw closed 7 years ago

mondegoftw commented 9 years ago

It's good time this gets looked at - makes horde retribution paladins entirely broken.

Seal of Blood procs from Crusader Strike (should not happen).

Seal of Blood procs Windfury Totem (should not happen).

This makes horde ret paladins ~completely~ broken. They are by far the most broken spec here. The fix is simple.

mondegoftw commented 9 years ago

Refer to this comment/thread for Crusader Strike SoB procs: https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/3482#issuecomment-107695595

dangreenberggit commented 9 years ago

This is a duplicate of #3482 ?

Missed SOB hits proccing Windfury attacks. Please provide evidence of this.

mondegoftw commented 9 years ago

I'm not sure what causes it, and don't have access to anything that'd let me test it at the moment, but the damage of SoB is way off. SoC seems about right, and SoB should do about 10% more dmg than SoC. So since SoC is ~25% total damage in a normal ret pal rotation, SoB should be ~27.5%.

It's closer to 50.

I don't know exactly what's causing the bug, but I'm pointing you in the direction of a really huge bug. Things like these can't be ignored on a server that's meant to be blizzlike.

Nick91 commented 9 years ago

The bug lies with Windfury Totem itself and not with SoB. (Only partially correct, see my comment below.)

https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/2865#issuecomment-19391194

As suspected this has been changed with a hotfix applied 2007/8/10 (http://blue.mmo-champion.com/topic/18088-10-08-windfury-totem-hotfix/).

Current situation:

The Windfury effect (http://database.wow-one.com/index.php?spell=25582) gained by the Windfury Totem (http://database.wow-one.com/index.php?npc=15497) does procc of any attack, such as Sunder Armor, Harm String, Rend and similar.

Desired situation:

The Windfury effect (spell=25582) should solely procc off white damage abilities (Auto-attack, sword spec-procc) and abilities which turn your next White damage attack into a Melee special attack (so-called On-next-hit-abilities such as Cleave spell=25231 and Heroic Strike spell=29707).

The comment is from an issue that is closed but not fixed.

Examples:

Current:

Desired: (assuming a WF attack is meant to be capable of triggering a subsequent WF, and a WF attack procs Seal of Blood)

mondegoftw commented 9 years ago

That probably explains some of it; but I'm sure it's not all of it because it still doesn't explain how SoB does more damage than white hits. That can't be caused solely by WF proccing too much, since if anything that'd increase white hits and sob damage proportionally, keeping SoB at roughly half as much dmg as white.

mondegoftw commented 9 years ago

https://www.youtube.com/watch?v=KCdcrclg8B4 proof ret pala dps isn't blizzlike - i'm sure if you look into the numbers it's caused by SoB. His SoB does roughly 400 DPS, and his total dps is around/below 2k. Means SoB accounts for 20% of his damage. And on feenix, SoB is at least 40% of damage.

Only WF totem bug would NOT make SoB do twice as much damage relative other spells. There's a bug with SoB (beyond WF and CS bugs). Probably it's in the damage calculations. Incidentally, SoR damage calcs are off too.

kildrazien commented 9 years ago

It's worth noting the post date of the video is in 2012, and the forum post that is linked in the description was posted in 2013. This leads to the conclusion that it is not necessarily blizzlike, as it could be on a private server.

Nick91 commented 9 years ago

Yes, the video posted in the comment above(https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/3688#issuecomment-133941835) is from a private server.

@roblockster Please re-evaluate the labels for this issue, now that a bug has been identified with the spell itself; description and reproduction guide see below.

I don't have access to the PTR to do more sophisticated tests, however I looked into your concern regarding that the damage SoB does is too high, logged my Horde Paladin and swung a target dummy. I came to the conclusion, that, circumstantially, Seal of Blood is doing more than the intended damage.

http://forums.elitistjerks.com/topic/9664-paladin-seal-mechanics/

I'm not sure if this is what you're actually asking - what spell damage coefficient does Seal of Blood get? The answer is zero. Seal of Blood receives absolutely no bonus whatsoever from +damage.

http://web.archive.org/web/20080221133542/http://forums.worldofwarcraft.com/thread.html?topicId=104544938&sid=1&pageNo=6

  1. How come JotC (additional holy damage) doesn't really give a damage boost to seal of blood?

3) Seal of Blood itself has no spell damage coefficient

Considering these two sources, there is a partial bug with the damage dealt by Seal of Blood. Spell damage from gear does not influence the damage dealt by the Seal, but the full bonus from a Judgement of the Crusader is applied to each melee swing. With Rank 7 that is 219, if applied with Libram of Zeal +47, it's 266.

Current bugs related to Seal of Blood

[1/3] The Seal damage scales 100% with the holy spell damage bonus of Judgement of the Crusader

Desired: The Seal damage is not supposed to be affected by Judgement of the Crusader at all. [1] [2] Reproduction guide see below.

Note that the damage of Judgement of Blood, the spell triggered if you use Judgement while being self-buffed with Seal of Blood, is supposed to be affected by Judgement of the Crusader by (1.5/3.5)%.

Reproduction guide

You will require one client in order to reproduce this issue

Create a Paladin .levelup 69 .gm off .gm visible on .learn 202 (Two-handed Swords) .add 35015 .t orgr .go c dummy .learn 27158 (Seal of the Crusader) .learn 31892 (Seal of Blood) .learn 20271 (Judgement) .max

[2/3] Crusader Strike is triggering damage dealing Seals (such as Seal of Blood)

Desired: Crusader Strike is not supposed to trigger damage dealing Seals, see Issue #3482 (With reproduction guide but unlabelled!)

[3/3] The Windfury Totem Effect is triggered by yellow attacks (such as Seal of Blood)

Desired: The Windfury Totem Effect is supposed to be triggered only by white attacks, see Issue #2865 (Closed but not fixed; not on live!)

Note that the bugs listed as 2/3 and 3/3 are heavily intertwined: Crusader Strike has, as a yellow attack, a chance to trigger the Windfury Totem Effect. The Seal of Blood triggered by Crusader Strike has also a chance to trigger the Windfury Totem Effect.

Take a look at my previous comment (https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/3688#issuecomment-133517164) to see how many chances for WF procs an example attack/ability sequence currently grants (bugged) and how many it is supposed to grant (after a fix).

mondegoftw commented 9 years ago

Thanks a bunch, Nick91. I was convinced there was a 3rd bug relating to the actual SoB proc number, but wasn't able to find the exact source without access to PTR or a horde paladin.

Well done. Can't wait for this to be fixed.

dangreenberggit commented 9 years ago

The holy damage bonus from Judgement of the Crusader is currently separate from the spellpower bonus it provides to holy spellpower-based spells, and is applying an extra source of holy damage to Seal of Blood and Seal of Command (27170) equal to damage bonus described in the tooltip.

Summary: -Seal of Blood has no spellpower coefficient but is incorrectly receiving additional damage from Judgement of the Crusader on the target. -Seal of Command has a spellpower coefficient and is receiving bonus damage both from the extra spellpower of Judgment of the Crusader (correct), and then again from this additional Judgement of the Crusader damage (incorrect).

endemol88 commented 9 years ago

The seal only scales with weapon damage, not spell damage. It therefore heavily favors melee-geared Paladins (mostly Retribution Paladins), rather than spelldamage-geared Paladins. Note that the Judgement does scale with spell damage. Source ===> http://wowwiki.wikia.com/wiki/Seal_of_Blood

Cerebov commented 9 years ago

reply to nick91's comment.

first of all, 4) i would like to remind about this issue https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/3483 this bug affects SoB and SoC and is actually decreasing their damage. 2). https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/3482 this was reported earlier. I dont have anything to add, exept i would like to clarify that Crusader strike activates only Seal of Blood and Seal of Righteosness atm(live), it doesnt affect Seal of Command and Seal of Vengeance. pls dont fix what is not broken. (in this way anyways, see https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/3240 ) 3) My testing today showed that Windfury attack doesnt proc off Seal of Blood. ( and Seal of Command) You can actually test it yourself. Get a pally and a shaman. Put wf and healing stream(to negate SoB backlash). Dont forget to renew totems every 2 mins. Hit a dummy for 100 hits.(count them yourself) U would see in recount ~120 autoattacks. Now do it with SoB up(dont forget to renew it every 30sec). You would see in the end ~120 autoattacks and ~120(depending on your expertise stat) SoBs in your recount. Dont forget to renew SoB and totems.( i switched to my shaman and renewed totems every 25 swings). Do it couple of times and round the results. If that assumption is true, you would see ~140 autoswings with SoB up, because having double chance of proc doubles the results. But you would get ~120 autoswings even with SoB up. Also, if WF does in fact proc off SoB swing, you would also see things like Crusader strike->SoB swing->WF swing (off SoB)->SoB (off WF swing). IF you cast Crusader strike inbetween autoattacks, that would happen sometimes and there would be no autoattacks that mislead you. But in 2 years raiding as ret pally ive never seen it happening. Same thing goes for SoC. with the bugged belay atm its easy to notice that standalone delayed SoC swing or Crusader strike+SoB swing never proc WF swings. Not a single yellow paladin attack procs Wf. Again, dont fix what is not broken.

Cerebov commented 9 years ago

Now for 1). this is the hardest part

http://wowwiki.wikia.com/wiki/Seal_of_Command_%28old%29?oldid=1634044 suggests that there are 2 coefficients for SoC - simple +spelldamage and +holy dmg, and JotC that acts like a separate enhancer for holy spells, not a simple +spelldamage addition.

"Seal of Command receives 20% coefficient from normal +spell damage stats, and 29% from +holy damage stats (such as Judgement of the Crusader). Judgement of Command receives 43% coefficient from any +spell damage stats. "

Does it mean that mean that SoB has are 2 coefficients too? +spelldamage(=0), and +holy dmg?

I can hardly belive that Seal of the Crusader doesnt do anything to SoB, because SoB is like the only spell that could benefit from JotC. It was always considered that JotC on the target is a must for any ret.

I think i saw some post somwhere that had JotC coefficients for all pally spells and SoB was something like +0%spelldmg +(30-40)% holy dmg. Its not +100%, that i agree.

gonna look into this.

repae1f commented 8 years ago

Seal of Blood spell coefficient 0.0 http://web.archive.org/web/20081218133415/http://elitistjerks.com/f47/t19038-spell_coefficients/

lajhar commented 7 years ago

Fix confirmed on PTR. SoB damage does not proc off Windfury attack (nor does Crusader strike, or any yellow attack). Seal of Blood damage does not scale with Judgement of the Crusader anymore. Crusader Strike does not activate damage seals (such as Seal of Blood)

lajhar commented 7 years ago

Already on live (15.6)