FeenixServerProject / Archangel_2.4.3_Bugtracker

This is the official Issue tracker for the Archangel 2.4.3 realm https://www.wow-one.com
78 stars 74 forks source link

Talent - Nature's Grace #3915

Open ernsss12 opened 7 years ago

ernsss12 commented 7 years ago

Hello.

Druid talent "Nature's Grace" in balance tree should give the caster 0.5 sec reduced cast time on the next spell after a spell critical strike.

If the druid has no haste rating Starfire goes from 3 seconds to 2.5 seconds with Nature's grace as it should.

However, if you have haste rating it doesnt reduce casting time by 0.5 sec. For example. If the druid has 250 haste rating it goes down by only 0.45 seconds. And wrath even less than that.

It seems like the issue is that Nature's Grace is reducing cast time with some amount of %.

Have anyone else thought about this issue?

Can any developer check this out?

Best regards

deathstreal commented 7 years ago

Nice find, should be easy to reproduce. To make it clearer for any dev that may read; Nature's Grace apparently scales with Spell Haste, but it is a negative effect.

lajhar commented 7 years ago

Report Confirmed. Spell haste rating affects the amount of casting time reduction of Nature's Grace.

Nature's Grace should have a fix 0,500 sec reduction effect.

an-sche commented 7 years ago

I think I've figured out why this is happening. Please correct me if I make any mistakes here.

  1. I assume this is the formula used in calculating cast speeds:

Haste Value = ((Base Cast Time / Hasted Cast Time) - 1) 15.77 100 (Copied from Delinquent's Forum Post, replacing 12.85 with correct value of 15.77)

  1. Without Nature's Grace: Calculate the cast time of wrath with 320 haste value and 1.5s base cast time, You receive a hasted cast time of 1.2469s. (Shown in @lajhar 's post above)

  2. With Nature's Grace: Calcuate the cast time of wrath with 320 haste value and a 1s base cast time. You recieve a hasted cast time of 0.8313s. (Also shown in his test above).

What does this mean?

The Nature's Grace effect seems to be calculated on the base cast time of Wrath rather than the hasted cast time of Wrath.

So, the formula is currently:

Haste Value = (((Base Cast Time -.5s if NG) / Hasted Cast Time) - 1) 15.77 100

It should be:

Haste Value = ((Base Cast Time / (Hasted Cast Time +.5s if NG)) - 1) 15.77 100

NOTE: In the second formula it's plus instead of a minus.

EDIT: To solve for cast time C = Cast time, H = Haste percent, B = base (1.5 for wrath)

Current: C = (B - .5 if NG)/(H+1)

Should be: C = (B/(H+1)) -.5 if NG

owlbama commented 7 years ago

Can we expect a fix for this soon? Gimping an already shit dps spec /cry

owlbama commented 7 years ago

Bump

owlbama commented 7 years ago

Bump..

ernsss12 commented 7 years ago

Are we expecting a fix on this soon?

Would be appreciated a lot!

owlbama commented 7 years ago

Fix?

Zerixx commented 7 years ago

Guys, this is a very deeply rooted issue, I've found. To fix this would require a substantial change. Don't count it out, but it's not something I can just fix immediately. Sorry for the bad news :(