FeenixServerProject / Wrath_3.3.5_Issue_tracker

The official issue tracker for Wrath 3.3.5
4 stars 4 forks source link

[3.3.5] Script Thorim Initial Threat and P2 Entry #199

Open HelloKitty opened 7 years ago

HelloKitty commented 7 years ago

Description:

Thorim, like many bosses at the moment, is managing a hostile list for players before he engages after gauntlet. This causes issues on transition from gauntlet to p2.

Current behaviour:

The issue causes him to not always jump down and instead attack a high threat healer who may also be on the platform or walk through the air to the target with threat. I don't know exactly if he should or shouldn't generate threat during p1 but I think it's unlikely based on the videos I've seen.

He should also not immediately jump down.

Expected behaviour:

He should not generate threat on any target until p2. He should instead jump down this video at 1:44 and only then begin adding hostiles to the threat list.

This video at 1:28 shows that his jump should not be immediate. He delays before jumping into the middle. Once again, only then does he start allowing threat generation.

Solution:

When Area Trigger with ID 5357 is triggered he should wait about 2 or 3 seconds and then jump into the ring and begin managing a hostile list. A quick hack fix might be setting the threat of all hostiles to 0 after he hands in p2.

HelloKitty commented 7 years ago

@Fapswhenoom @Zerixx My recommendation is to use the AT 5357 to start p2. From my few attempts of Thorim in-game I noticed that he wasn't using the area trigger. I made a commit that adds it here: https://github.com/HelloKitty/TrinityCore/commit/4e56d34e616c2fdf338776ac7833e2eac754ba3e

I can't really see a clean way to tell TC a specific NPC shouldn't maintain a hostile reference table. I don't think there are any relevant Unit or NPC flags. In fact, right now I'm having issues removing IMMUME_PC flags from Thorim for some reason. Don't know why lol.

edit: Easiest thing to do might just be to not enter combat until after the jump and wipe threat right before that happens.

Tapswhenoom commented 7 years ago

This is exactly what happens, but I think it's triggered when he starts the jump down. When he jumps down het gives the nearest player 1000 threat initially. I'll have to do some playtesting to see the problem with more toons who have hots running and stuff