XT-002 Tantrum Damage Calculation

[HelloKitty]

I believe that ID - 62776 Tympanic Tantrum is currently calculated partially correctly, it deals 10% every tick with:

void RecalculateDamage()
{
        SetHitDamage(GetHitUnit()->CountPctFromMaxHealth(GetHitDamage()));
}

However, it appears to be taking armor into consideration. I'm unaware how what spell attributes/flags are needed to indicate that it should ignore armor. Maybe the spell itself is missing that flag? Because Unit has a method to determines if a spell should ignore armor.

Anyway, however it can be done the spell damage is physical but should ignore armor.

[HelloKitty]

Try adding SPELL_ATTR4_FIXED_DAMAGE to the Tantrum spell in SpellMgr::LoadSpellInfoCorrections(). Should make it ignore armor I think. I never used that attribute nor have I used SpellInfoCorrections. Should work though.

[HelloKitty]

Hmmm, you should use attribute SPELL_ATTR0_CU_IGNORE_ARMOR instead of FIXED_DAMAGE to avoid encountering an issue that was on Dalaran where other abilities that should be reducing that damage weren't.

From WoWHead

Almost each class has an ability or combination of abilities that helps mitigating the damage of tantrums:

Druids: Barkskin Hunters: Roar of Sacrifice + Shell Shield Paladins: Divine Sacrifice + Divine Shield Rogues: Feint Priests: Pain Suppression or Dispersion

See: this issue