search

Fefedu973 / SignalRGB-To-OpenRGB-Bridge

An add on for signalRGB that allows to control OpenRGB Devices
4 stars 1 forks source link

Incomplete package.json | builds can't be reproduced #5

Open Oxalin opened 3 months ago

Oxalin commented 3 months ago

Package.json file is incomplete: Missing dependencies, scripts, etc. This prevents building the code and testing it.

Obviously, this must be set somewhere since releases are available.

Fefedu973 commented 3 months ago

Package.json file is incomplete: Missing dependencies, scripts, etc. This prevents building the code and testing it.

Obviously, this must be set somewhere since releases are available.

I need to look into that. I build the server.js using PKG I gave the command in an issue but idk how the integrate it into the package.json

Fefedu973 commented 3 months ago

Let me find the command I use... But thanks a lot for all your constructive feedback! 👍

Oxalin commented 3 months ago

Under "scripts": {}, you'll need to define a command for your build to run. I've been playing a bit with the source code and you could start with something like

"scripts": { "build": "npm run clean build:app", "build:app": "npm run set-version && ''", "clean": "rimraf build dist", "format": "echo 'some code to prettify your code'", "set-version": "echo 'ex. to set version: node ./resources/scripts/set-version.js'", "start": "npm run start:build", "start:build": "npm run clean && npm run set-version && npm run start:server", "start:server": "node --max-http-header-size=1638400 server.js" }, "dependencies": {...

Oxalin commented 3 months ago

If you are open to it, I could fork your code and propose a few pull requests.

Fefedu973 commented 3 months ago

Oh yes, that would be great! I don't have much time these days, so your help is most welcome.