search

Fekide / volumerize

Docker Volume Backups Multiple Backends
https://hub.docker.com/r/fekide/volumerize/
MIT License
8 stars 2 forks source link

Fixes google drive upload #15

Closed Miladiir closed 3 years ago

Miladiir commented 3 years ago

Fixes #14

Miladiir commented 3 years ago

Not sure how to bump versions, you guys may need to step in.

sargreal commented 3 years ago

Hey @Miladiir

what you suggest seems to work, i would however rather state the version requirement directly when installing, something like this:

diff --git a/Dockerfile b/Dockerfile
index 5201fb7..310f9e9 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -43,6 +43,7 @@ RUN apk upgrade --update && \
     pip3 install --no-cache-dir wheel setuptools-scm && \
     pip3 install --no-cache-dir \
       fasteners \
+      google-api-python-client>=2.2.0 \
       PyDrive \
       chardet \
       azure-storage-blob \
Miladiir commented 3 years ago

I agree, much more elegant. I updated the pull request.

sargreal commented 3 years ago

Thanks, it looks good to me :)