search

FeliciaBeatrice / pe

0 stars 0 forks source link

Minor error in Sequence Diagrams in DG #8

Open FeliciaBeatrice opened 2 years ago

FeliciaBeatrice commented 2 years ago

image.png

image.png

I am not very sure about this but I think the Duke activation bar for these two sequence diagrams should be replaced by a dotted line instead since there are no methods calling it and it is also not returning anything. Alternative: it should have an arrow pointing to the start of the activation bar like the other sequence diagrams in the DG

nus-pe-bot commented 1 year ago

Team's Response

From the textbook, the activation bar represents the period which the method is being executed. In the application, the run() method of Duke is executed. As such, I don't find it as an error for adding an activation bar for it.

image.png

If you disagree with my judgement, we should let the teaching team decide on this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I don't particularly disagree but I'm a bit confused as for the other sequence diagrams, there is an arrow pointing to Duke. I'm not sure if that's an inconsistency or anything but I'll let the teaching team decide.