Felicis / Water-Physics-Overhaul

MIT License
37 stars 4 forks source link

Water in the ocean randomly disappears #11

Open xJiggo opened 1 year ago

xJiggo commented 1 year ago

When I look at the ocean I see little holes in the water that are generated more and more and when I go over there it will all just fall in lowering the sea level constantly. Hope you could help thanks

Love this mod keep it up 👍 2023-06-05_22 06 42

Felicis commented 1 year ago

that looks funky xD Waterlogging is not really tackled on worldgen yet, so I am expecting these kinds of bugs to be there. They'll have to be fixed, once I fixed the waterlogging problems.

Anyway have you had a closer look at the leak and seen if there are massive amounts of not-waterlogged blocks being waterlogged (e.g. water plants) or if there is a hole/cave somewhere that drains the ocean? I can't really tell what is happening from the picture.

xJiggo commented 1 year ago

The caves were already filled with water but the water is randomly disappearing because its just like sorta deleting itself I have no idea how but here is how far the water dropped now. Also to note I converted this world from 1.16.5 to 1.18.2 could that maybe be the problem or is it something completely different?

2023-06-08_21 28 00

Heres a vid of it:

https://github.com/Felicis/Water-Physics-Overhaul/assets/135664340/7d96a064-4d16-4754-9a8d-ddd13d81e603 See how spots appear then go because I'm near

djmrFunnyMan commented 1 year ago

This could be because any water below Y=0 get's deleted currently (big bug) so the ocean water is getting sucked into that.

Felicis commented 1 year ago

There is also still several bugs with waterlogging, where water is getting duplicated or destroyed. But there is no point tackling them until waterlogging is fixed #2... I'll let you know when it's done :)

xJiggo commented 1 year ago

Thanks keep it up 👍