Felicis / Water-Physics-Overhaul

MIT License
34 stars 4 forks source link

Water forgets to slide and equalize. #22

Open djmrFunnyMan opened 1 year ago

djmrFunnyMan commented 1 year ago

This is more obvious when you increase the sliding and equalization distance (both set to 32 for this test). The water just forgets to slide and equalize and needs to be manually updated to work again (for example with a flint n' steel). Sometimes water that's already moving towards the hole also just freezes in place for no reason and needs to be updated again to resume.

Initial state: 2023-06-19_14 16 51 After forcing block updates multiple times: (issue #21 also visible) 2023-06-19_13 46 42

Addendum: After making the hole smaller (1x1 instead of 3x3) I noticed the water can in general just completely forget to follow the laws of physics 2023-06-19_14 40 21

djmrFunnyMan commented 1 year ago

If this cannot be easily fixed perhaps water could be made to update using random ticks instead of block updates which'd let it eventually sort itself out on it's own without requiring the player to run around updating every water block manually.

(pretty sure liquids used to be affected by random ticks before update 1.12.2 btw)

Felicis commented 1 year ago

nice analysis :+1: . It would be nice to see if the newer version (nightly) has the same issues. also fyi the new fluid system has random fluid ticks