FelicitusNeko
commented
5 months ago Apologies for sitting on this forever. I finally got around to reviewing and testing this, and there's no reason I should have waited this long for it.
Looks good, just have some notes, on the off chance you're even interested in doing any more with this:
- The text becomes a little distorted when the window is resized (not sure if SDL has a smoothing/anti-aliasing option)
- Crosshairs get drawn on dying enemies (I honestly forget if this is present in vanilla)
- The sprite for the Hunter (endgame enemy) gets glitched sometimes; the sprite's source X position gets skewed half a sprite width to the right (again not sure if this is present in vanilla; the escape sequence is very chaotic and it can be hard to tell anything going on)
- A couple of glitches during the end sequence:
- Single-frame blue flashes during the whole-world pan before the first wall of text
- The first wall of ending text draws incorrectly; it starts out all visible, fades out line by line, then fades back in before moving to the next part of the ending (the exact opposite of the expected behaviour)
Also no music, but that's a function of SDL_mixer not being built with MOD support by default. Looks like the current version builds with libxmp, so no need to write new code there; I'll probably just need to build and bundle SDL_mixer with MOD support.
Overall works well enough for me to merge so I can work on a new release to cover AP 0.5.0 changes.
This is my first ever pull request, so forgive me if I've put this in the wrong spot.
I didn't necessarily update it in the most efficient way, but I don't believe I've introduced any behaviors that weren't already in the base game to my knowledge. I've tested on my machine by doing a full playthrough on 3 versions for visual comparison: The current release candidate compiled natively from source, the current release candidate from the releases page using Wine, and of course my branch compiled natively from source (I'd try and cross-compile my branch to test that on Wine for 4 comparisons, but frankly I don't know how yet). Please test this on an actual Windows machine because I don't have one. It should work fine, but I can never rule out OS-specific issues.
The only other things of note that I've added that weren't strictly necessary for SDL 2 to work are allowing for window resizing (and it respecting aspect ratio). I also found myself needing to debug the rendering code so I added a way to compile for debugging in the makefile. Lastly, I added savefiles and the linux executable to the .gitignore because for my testing I needed to move and keep multiple savefiles around to test at multiple states of the game, and also because well, the windows executable was already in the .gitignore.