FelipeFTN / Emoji-Copy

😄 Emoji copy is a versatile extension designed to simplify emoji selection and clipboard management.
https://extensions.gnome.org/extension/6242/emoji-copy/
GNU General Public License v3.0
106 stars 12 forks source link

Sometimes, but not always, clipboard contents are appended to rather than replaced #19

Open psycotica0 opened 10 months ago

psycotica0 commented 10 months ago

Bug Report

Current Behavior I don't know when it starts or when it stops. I just tried a bunch, both with the keybinding, and searching, and arrow keys, and clicking emoji with the mouse, and just kept picking some, then pasting, then copying something else, then pasting, and it mostly worked the way I expected which is that the clipboard's value is just the one emoji I picked.

But eventually it will switch to instead adding the emoji onto the end of the clipboard, even if there's text in there, and then I'll end up pasting whatever that was and then having to delete most of it to get down to just the emoji on the end I want. I haven't found the pattern yet...

Expected behavior/code I expect that after I've picked an emoji my clipboard will contain only that emoji and its previous contents will be lost.

Environment

FelipeFTN commented 10 months ago

Hey @psycotica0!! Thank you for your help finding these things! :smile: You're doing such a nice job! Maybe cleaning the clipboard before copying a new emoji into it should work, don't you think? This could be an interesting addition to the code, hope this works. I will be testing it soon, the copy-paste functions must be polished, and you are doing a great work by finding it! Thank you a lot!! :1st_place_medal:

psycotica0 commented 10 months ago

Interesting... I've been using Emoji Selector for years and never remember it having this problem, so I thought this may be a new problem. But maybe not? Did the clipboard handling code change at all in Gnome 44/45?

FelipeFTN commented 10 months ago

I don't think I changed anything too much problematic while migrating this functionality, but it's always possible. I think the clipboard handling didn't change in anything but libraries imports and stuff. Anyways, I will take a look at this! Thanks for the suggestion!

NatVIII commented 10 months ago

I don't want to be dismissive but is it possible you may have been accidentally right clicking on emojis? What you're describing is the functionality for right clicking emojis, perhaps you have a trackpad that can click the wrong mouse button sometimes? Please see if it can be replicated though, if you're definitely clicking the lmb and it's still happening and provable then it's a bit of an issue.

psycotica0 commented 10 months ago

I'm sure, because I don't use the mouse at all in normal operation.

Typing, and arrow keys, and enter; no mouse

On December 1, 2023 11:53:19 p.m. EST, NatVIII @.***> wrote:

I don't want to be dismissive but is it possible you may have been accidentally right clicking on emojis? What you're describing is the functionality for right clicking emojis, perhaps you have a trackpad that can click the wrong mouse button sometimes? Please see if it can be replicated though, if you're definitely clicking the lmb and it's still happening and provable then it's a bit of an issue.

-- Reply to this email directly or view it on GitHub: https://github.com/FelipeFTN/emoji-copy/issues/19#issuecomment-1837039940 You are receiving this because you were mentioned.

Message ID: @.***>

tom-ricci commented 6 months ago

I'm noticing this on Gnome 42. It seems to be consistent actually, whenever I navigate to an emoji via the keyboard, it will append. If I click on the emoji with the mouse, it works as intended.

I also notice that the emoji picker only automatically disappears when using the mouse to select emoji. Not sure if this is intended behavior, but my first thought was that it was related to this issue.