--color=never is not a valid option for ag

[fabacino]

The option --color=never introduced in https://github.com/FelipeLema/emacs-counsel-gtags/commit/af1ecbc2ecc235281bc3a86871c824bdf962eaf2 does not always work, e.g. ag uses --nocolor instead.

I created a new variable counsel-gtags--grep-commands-no-color-options where the color suppressing options can be defined for each command in case they differ from --color=never which is used by default.

[FelipeLema]

This looks good, concise and easy to understand in itself.

This being said, I'm trying to keep a high standard for this code (since it was very hard to maintain to begin with)

• can you add unit tests for this? it looks like you'll have to modify the travis yaml file to have ag available (feel free to propose a more suitable docker image).
• please document counsel-gtags--grep-commands (and maybe counsel-gtags--grep-commands-no-color-options) elsewhere (probably in counsel-gtags--get-grep-command's docstring, maybe somewhere else). This way, devs in the future can better understand how these variables can affect the functionality of this package's functions.

Thanks for taking the time to do this.

[fabacino]

I tried to improve the things you were pointing out. Let me know what you think about it.

[FelipeLema]

it looks good and clean

thanks for taking the time to work on this

[fabacino]

Thank you for keeping this package alive and maintainable.