search

FelipeLema / emacs-counsel-gtags

GNU Global with ivy completion
22 stars 5 forks source link

Add an option to use internal emacs candidates filtering #19

Closed Ergus closed 3 years ago

Ergus commented 3 years ago

This is explained in detail in the readme.

Also added 2 tests for the new function and condition.

FelipeLema commented 3 years ago

I like it that you've made this filtering-by-external-command explicit

Ergus commented 3 years ago

I like it that you've made this filtering-by-external-command explicit

After my tests and using it daily; the best would be to completely remove all the grep/rg/ag calls because up to now the static one is much faster than with the external filtering in all my use cases. It also simplify the code and avoid all the grep searching and so on... But I don't have actually time to do that and maybe it will affect some users already using the package (if any). I think it only makes sense when the number of candidates is huge (maybe in the order of ~100k) because up to now the static is faster (and simpler).

FelipeLema commented 3 years ago

do mind that the external command filtering was added because using a counsel-async-command took a lot of time to filter-and-show-current-entry and it was sluggish to use. I happened to have this problem, although it was reported by someone else.

I understand that the default value may be on or off, but the option must stay there for the final user