Issue in global-tags - Githubissues

FelipeLema / emacs-counsel-gtags

GNU Global with ivy completion

22 stars 5 forks source link

Issue in global-tags #23

Closed Ergus closed 3 years ago

Ergus commented 3 years ago

Hi Felipe:

Sorry for reporting here, but I don't know how to report issues in the other page (I really didn't tried too much either).

The latest changes in global-tags created some issues in my system. Checking the code I see the variable global-tags-exclusive-backend-mode in the global-tags-shared-backend-mode so the shared mode is broken because it never becomes enabled and I get this:

FelipeLema commented 3 years ago

as long as the message gets through... I don't mind

I just uploaded a fix... keep an eye out for melpa update

Ergus commented 3 years ago

BTW when loading the package I get this two warnings:

global-tags.el: ‘project-roots’ is an obsolete generic function (as of 0.3.0); use ‘project-root’ instead.
Eager macro-expansion failure: (error "Attempting to set a non-symbol: 'xref-backend-functions")

They are very simple to fix, just use the other function and remove the quote in (setq-local 'xref-backend-functions

Also in the remove-hook calls like:

(remove-hook 'xref-backend-functions 'xref-backend-functions)

I don't think are fine.

Best, Ergus

FelipeLema commented 3 years ago

my bad. just uploaded a fix for this.

Ergus commented 3 years ago

Hi Felipe:

The package is much better now. Maybe it may be interesting to add it to Elpa or the new non-gnu Elpa repositories to improve visibility for those users not using Melpa. As you are the only contributor it may be simple to do; because usually the complicated part is to gather the copyright assignment for all contributors.