search

FelipeLema / emacs-counsel-gtags

GNU Global with ivy completion
22 stars 5 forks source link

Fixed collect pattern and no line variable error. #4

Closed Ergus closed 5 years ago

Ergus commented 5 years ago

There are still some issues with tramp because the tramp prefix is missing.

FelipeLema commented 5 years ago

Please add a unit test for testing the code change.

Right now the tests are not covering all the code and all code we've been adding have unit tests to avoid technical debt.

Thanks

FelipeLema commented 5 years ago

You should also remove the get-grep-command-from-default-emacs test since it's no longer needed.

Ergus commented 5 years ago

Hi with your changes the mine are not needed anymore (looks like), So I will cancel the request. But remember there is another multiple-value-bind in counsel-gtags--get-files