search

FelipeLema / emacs-counsel-gtags

GNU Global with ivy completion
22 stars 5 forks source link

Some minor fixes. #5

Closed Ergus closed 5 years ago

Ergus commented 5 years ago

counsel-gtags--process-lines: cleared the buffer before the process-file call because results were accumulating.

counsel-gtags--select-file: added a check condition to not call global with an empty tag candidate because the error was being printed in the ivy buffer. (counsel-gtags--read-tag could return nil)

This is just a bugfix, so I don't know if you need a test for this.

Ergus commented 5 years ago

Hi Felipe:

I added 2 commits one fixes some byte compilation warnings I had and the other fixes some issues. You don't have to accept them because they don't have tests, but at least consider the fixes in the future changes.