[PA Review] Project Proposal

[niartenyaw]

Great work on your proposal! Please find my feedback below. You will need to incorporate these changes before you begin coding on Tuesday after A06. Feel free to work on this today so you're ready to hit the ground running tomorrow!

General

• [x] Notifications and Feeds: Since these are bonuses, don't worry about these yet. For now, just move them to the bottom of each page under a Bonus heading so they aren't in the way. If you get to them, we can talk about the different ways to implement them.

DB Schema

• [x] Don't include a new_notifications portion yet since it's a bonus MVP.
• [x] Move notifications and feeds tables to a bonus header at the bottom for now
• [x] You won't have to include uploader_username or uploader_profile_url because we can get that information by following the uploader_id foreign key.

API Endpoints

Looks good! 👍

• [x] To pass a user_id to the photos index (get all of a users photos they have posted), I would use a nested route like GET api/users/:user_id/photos instead of GET api/photos/:user_id
• [x] Remove the notifications and feeds routes for now

State Shape

• [x] I would recommend against keeping an array of ids in each entity, for instance, photo_ids: [4,8,3] in each user. This is because if a user adds or deletes a photo, that change now has to be reflected in both the pictures slice of state and the users slice of state. We want to try to catch an action only in one reducer to keep our logic clean. Having that array of ids could have performance benefits, but clutters our logic.
• [x] To account for that, you'll now need a follows slice of state
• [x] In each picture, you have comment_ids: [1,5,11] and liker_ids: [1,5,11] but it doesn't look like either are an MVP based on your MVP list. If you'd like to add one of them, you're welcome to move Home Feed and Profile Page to be the same MVP.
• [x] Remove the notifications and feeds slices for now
• [x] What is the affection inside of a user?

Frontend Routes

Looks good!

• [x] /users/:edit will probably be /users/edit since edit isn't a wildcard

Component Hierarchy & Wireframes

Great work!

• [x] Will the Photo show need a container?
• [x] Move notifications section to bottom with Bonus header for now

[FelixAlvarado]

Thank you for the feedback. I completed the necessary changes. Comments and likes are things I was planning to add as bonuses, but will more than likely not have time. It is still something I would like to revisit and complete during job search. Also, affection is the amount of likes a user has from all their photos.