Open niartenyaw opened 6 years ago
Thank you for the feedback. I completed the necessary changes. Comments and likes are things I was planning to add as bonuses, but will more than likely not have time. It is still something I would like to revisit and complete during job search. Also, affection is the amount of likes a user has from all their photos.
Great work on your proposal! Please find my feedback below. You will need to incorporate these changes before you begin coding on Tuesday after A06. Feel free to work on this today so you're ready to hit the ground running tomorrow!
General
Bonus
heading so they aren't in the way. If you get to them, we can talk about the different ways to implement them.DB Schema
new_notifications
portion yet since it's a bonus MVP.notifications
andfeeds
tables to a bonus header at the bottom for nowuploader_username
oruploader_profile_url
because we can get that information by following theuploader_id
foreign key.API Endpoints
Looks good! 👍
user_id
to the photos index (get all of a users photos they have posted), I would use a nested route likeGET api/users/:user_id/photos
instead ofGET api/photos/:user_id
notifications
andfeeds
routes for nowState Shape
photo_ids: [4,8,3]
in eachuser
. This is because if a user adds or deletes a photo, that change now has to be reflected in both thepictures
slice of state and theusers
slice of state. We want to try to catch an action only in one reducer to keep our logic clean. Having that array of ids could have performance benefits, but clutters our logic.follows
slice of statepicture
, you havecomment_ids: [1,5,11]
andliker_ids: [1,5,11]
but it doesn't look like either are an MVP based on your MVP list. If you'd like to add one of them, you're welcome to moveHome Feed
andProfile Page
to be the same MVP.notifications
andfeeds
slices for nowaffection
inside of auser
?Frontend Routes
Looks good!
/users/:edit
will probably be/users/edit
sinceedit
isn't a wildcardComponent Hierarchy & Wireframes
Great work!
Photo show
need a container?Bonus
header for now