PA Review: Profile Page

FelixAlvarado / 360px

16 stars 0 forks source link

Open FelixAlvarado opened 6 years ago

FelixAlvarado commented 6 years ago

[x] Backend: DB, model, controller, views
[x] Redux Loop: ajax, actions, reducer
[x] Presentational Components and Containers
[x] Styling
[x] Adequate and appropriate seeds
[x] profile displays all of user pictures
[x] The displays the amount of people they are following, and the amount of followers they have
[x] There is an edit profile button where users can . upload their profile picture, cover photo, and change their description

niartenyaw commented 6 years ago

Awesome!

[x] This isn't really specific to this MVP, but has been most apparent on this page. You should probably have a footer to separate pictures from the bottom of the page. Maybe just some links to your github, etc.

FelixAlvarado commented 6 years ago

fixed it

niartenyaw commented 6 years ago

Nice! One more thing I just noticed:

[x] The cover photo for the profile seems to be stretched. You'll want to have a "cover"-like effect without stretching it. Try setting the min-width and min-height to 100% (make sure to handle the overflow too) to make it fill its parent