FelixBaensch / MORTAR

MOlecule fRagmenTAtion fRamework
MIT License
18 stars 3 forks source link

Introduce "production" branch and protect master branch afterwards. #27

Closed JonasSchaub closed 6 months ago

JonasSchaub commented 7 months ago

About master/main branch protection: I've done this very minimally in one repo now, simply checking the "Require a pull request before merging" option in the branch settings (without checking any sub-options there). Could this be something we do here as well?

FelixBaensch commented 7 months ago

I've also enabled "Require status checks to pass before merging" with SonarCloud status check, and "Require status checks to pass before merging".

JonasSchaub commented 7 months ago

That might be a bit harsh, we don't always fulfill all the SonarCloud quality gate requirements in terms of test coverage and code duplication 😅

JonasSchaub commented 7 months ago

I've created a production branch starting from the current main commit. Please merge your pull requests there from now on.

FelixBaensch commented 7 months ago

That might be a bit harsh, we don't always fulfill all the SonarCloud quality gate requirements in terms of test coverage and code duplication 😅

I will disable this point

Done

JonasSchaub commented 7 months ago

Thank you, I will notify you again should there be any problems with the main branch protection rule :D Is it actually transferred from master to main or do you have to adjust that? I think these rules work based on names, not behind-the-scenes branch ids.

FelixBaensch commented 6 months ago

It should be transferred automatically

JonasSchaub commented 6 months ago

Can you quickly check?

FelixBaensch commented 6 months ago

If I see this correctly all PRs where transferred from "master" to "main"