search

FelixBaensch / MORTAR

MOlecule fRagmenTAtion fRamework
MIT License
18 stars 3 forks source link

Rework method and usage of CollectionUtil.sortGivenFragmentListByPropertyAndSortType() #50

Closed JonasSchaub closed 5 months ago

FelixBaensch commented 5 months ago

What exactly should be improved here?

JonasSchaub commented 5 months ago

To quote the comment in line 51: "check parameters, change params to enum values (and bools?), throw exceptions!" I'll take care of it.

FelixBaensch commented 5 months ago

Exactly, I overlooked the comment. I'll do it, you don't have to do everything.

JonasSchaub commented 5 months ago

As you wish 🤷‍♂️ 😄

FelixBaensch commented 5 months ago

I don't know what is meant by the "bools", but the rest should be fixed, see #53

FelixBaensch commented 5 months ago

Closed, see #53