search

FelixBaensch / MORTAR

MOlecule fRagmenTAtion fRamework
MIT License
18 stars 3 forks source link

Unused parameter #52

Closed JonasSchaub closed 5 months ago

JonasSchaub commented 5 months ago

https://github.com/FelixBaensch/MORTAR/blob/9793153bc7dcac7220f76239b9d1612932f478ea/src/main/java/de/unijena/cheminf/mortar/gui/views/ItemizationDataTableView.java#L101

@FelixBaensch , the first parameter "anItemAmount" seems to be unused. Can I safely remove it?

FelixBaensch commented 5 months ago

If you customize the call as well

JonasSchaub commented 5 months ago

If you customize the call as well

... of course! But all in all, this is an artifact and the maximum fragment column number for the items tab is now determined in a different way, do I see this correctly?

FelixBaensch commented 5 months ago

Yes

https://github.com/FelixBaensch/MORTAR/blob/9793153bc7dcac7220f76239b9d1612932f478ea/src/main/java/de/unijena/cheminf/mortar/gui/views/ItemizationDataTableView.java#L164

JonasSchaub commented 5 months ago

Ah, thank you, didn't see that! I'll remove this param then 👍

JonasSchaub commented 5 months ago

Resolved by https://github.com/FelixBaensch/MORTAR/pull/49