Closed FelixBaensch closed 4 months ago
Does the histogram button in the fragments tab looks the same?
All of these buttons have the MORTAR standard size. I guess this has to be increased then. What do you think?
Maybe we have to explicitly set the font size, since this looks like an OS depending problem
this looks like an OS depending problem
...definitely. I've done a quick research and it seems to be discouraged to define a general "look and feel" for a JavaFx app. This way, the app can look "native" in each OS which is nice.
Setting the font can be done via the style sheet, e.g.:
.root{ -fx-font-size: 9pt; }
Setting the font type would be helpful but would make it harder to port MORTAR to other OS because the specific font might not be installed on the system. But I actually think the font is the bigger problem here than the font size...
Are you starting MORTAR from IntelliJ on your Linux system? Or via the JAR? So how could I give you a version with a defined font size to try it out on your system?
Both, so both will be fine
Could you then go to my sonar-issues-fix branch and try it out there? I simply added .root{ -fx-font-size: 9pt; }
to the style sheet. Feel free to play around with the value.
It fixed the overview button on the main page but not the rest
Then we either have to make the buttons bigger or the text even smaller... "Export CSV" and "Export PDF" could also be abbreviated to "CSV" and "PDF". What do you think?
"Export CSV" and "Export PDF" could also be abbreviated to "CSV" and "PDF". What do you think?
That was my suggestion from the start
I have done that on the same branch as before. I have also exchanged the "Histogram" button label with "Plot". I thought it sounds like a command "plot frequencies" and would fit. I am missing ideas how else to abbreviate the histogram button label. What do you think? And could you please check all the buttons again?
@FelixBaensch could you please test this again on my "sonar-issues-fix" branch? I would like to solve this for the new release.
Sorry for the late response. I probably won't be able to do it this week, but I'll test it at the beginning of next week.
No worries, this week is basically over anyway 😄
CSV and PDF look good to me, "Plot" might be a bit confusing. How about "Hist" or "Histo"?
@FelixBaensch please go to branch "issue-54-button-sizes" and let me know what you think.
Looks good
Linux Mint