FelixBaensch / MORTAR

MOlecule fRagmenTAtion fRamework
MIT License
18 stars 3 forks source link

CH3 is parent fragment of CH4 when using Scaffold Generator #87

Closed FelixBaensch closed 2 months ago

FelixBaensch commented 2 months ago

image

Scaffold Generator was applied to the attached test set (please remove the .txt extension) in default settings. ertl_alkenes.sdf.txt

JonasSchaub commented 2 months ago

You imported without adding implicit hydrogens to open valences, correct? At first, I thought the issue was about all the open valences i the input mols. And you set the Scaffold Generator Side chain setting to either "only side chains" or "scaffolds and side chains", correct?

In your SDF, the "CH3" input mol has a "3" set as the 6th property in its atom block. Does this define three explicit hydrogen atoms?

I'm guessing that the CH3 input mol gets saturated by Scaffold Generator into CH4. This looks weird at first glance but would actually be expected behaviour, in my opinion.

FelixBaensch commented 2 months ago

You imported without adding implicit hydrogens to open valences, correct? At first, I thought the issue was about all the open valences i the input mols. And you set the Scaffold Generator Side chain setting to either "only side chains" or "scaffolds and side chains", correct?

Yes, the file was imported without adding implict hyrdogens. And the side chain setting was set to "scaffolds and side chains", so not quite default settings after all, sorry.

In your SDF, the "CH3" input mol has a "3" set as the 6th property in its atom block. Does this define three explicit hydrogen atoms?

The 6th property in the atom block of a v2000 connection table stands for the valences. By default it is set to 0, which indicates the default valence.

I'm guessing that the CH3 input mol gets saturated by Scaffold Generator into CH4. This looks weird at first glance but would actually be expected behaviour, in my opinion.

If you say so, and that reflects the desired behavior, feel free to close the issue. I opened it at your request.

FelixBaensch commented 2 months ago

For the sake of completeness:

image

image