FelixBaensch / MORTAR

MOlecule fRagmenTAtion fRamework
MIT License
18 stars 3 forks source link

Fix for issue 88 that fragmenter settings in pipeline reflect back to fragmentation settings in main view #97

Closed JonasSchaub closed 2 months ago

JonasSchaub commented 2 months ago

Now made sure that fragmenter instances are always copied when used in the pipeline settings view controller. Also some renaming to make things more clear and also added a note about pipeline fragmenter settings to the tutorial.

JonasSchaub commented 2 months ago

@FelixBaensch, very sorry to bother you, but could you maybe test and review this? Please forgive me for the refactoring that makes the "actual" changes harder to see.

FelixBaensch commented 2 months ago

@FelixBaensch, very sorry to bother you, but could you maybe test and review this? Please forgive me for the refactoring that makes the "actual" changes harder to see.

I will leave these extraordinarily long variable names uncommented.... But I will review it in the next few days

JonasSchaub commented 2 months ago

@FelixBaensch I have restructured the code and removed everything that I regarded as legacy code. Could you maybe test whether I broke sth and whether the original issue is fixed?

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

JonasSchaub commented 2 months ago

@FelixBaensch I have made adjustments according to your requested changes. Do you approve?

FelixBaensch commented 2 months ago

Merge at will