search

FelixGail / gplaymusic

A Google Play Music API in Java
MIT License
54 stars 15 forks source link

Why are you filtering out tracks with no STOREID? #55

Open craiglowery opened 5 years ago

craiglowery commented 5 years ago

Nearly half of my tracks have no StoreID. Your pagehandler filters out tracks without StoreId or Uuid. I cloned and modified to suite my needs, but was wondering why this is hard-wired and not configurable?

FelixGail commented 5 years ago

related: #52

I am pretty sure I had a reason for this, but i have still not figured out what it was. I will accept the pending pull request as soon as i am back home after new year.

craiglowery commented 5 years ago

By the way, you are due a great deal of thanks for doing the port in the first place. Thank you for taking the time to answer such nit-picky questions.

caprica commented 5 years ago

Just an extra data-point, with the current filtering I get around 150 of my tracks returned. Without the filtering it returns over 5000, so whatever the reason, currently it limits the usefulness of this a bit.

Also, it looks like it's actually filtering out tracks with a store id, not those without.

And I agree, by the way, thanks for making this port available.

FelixGail commented 5 years ago

A version without filtering is available as snapshot on felixgail:gplaymusic:0.3.7-SNAPSHOT. If it works as intended i will create a new release - so i would be really grateful for someone to test it

caprica commented 5 years ago

Your snapshot version works for me.