FelixKratz / JankyBorders

A lightweight window border system for macOS
GNU General Public License v3.0
1.13k stars 18 forks source link

Can't install (with brew) on older than Sonoma #10

Closed nicocossiom closed 11 months ago

nicocossiom commented 11 months ago

I got the following when trying to install via brew on an M1 MBPro on macOS Ventura 13.6.1:

$ brew install borders

borders: This software does not run on macOS versions older than Sonoma.
Error: borders: An unsatisfied requirement failed this build.

So I built the binary manually and it works completely fine. Posting so requirements for the brew formulae are relaxed, at least for Ventura which is quite recent.

Also, this works very well, I was missing borders from yabai. Thank you!

kkreso commented 11 months ago

I tried it, it does work but with strange always visible overlapping borders.

image
FelixKratz commented 11 months ago

I no longer have a Ventura machine I can test the software with and since the APIs used here are prone to deprecations and changes between macOS version it is probably best to focus on Sonoma for now.

FelixKratz commented 11 months ago

I tried it, it does work but with strange always visible overlapping borders.

image

Could you try the following: remove the line

  SLSWindowManagementBridgeSetDelegate(NULL);

from main.c, compile and run the resulting binary and see if the strange ordering persists.

kkreso commented 11 months ago
SLSWindowManagementBridgeSetDelegate(NULL);

Tried, issue is still there. I appreciate your efforts, the borders really help differentiate the windows and make things easier to use. I'll upgrade to Sonoma probably just because of the JankyBorders.

nicocossiom commented 11 months ago

@kkreso you're right, since I use yabai I rarely have two windows stacked hence why I didn't see the overlapping borders. Will update to Sonoma in some time once it's more stable and use Janky Borders. Thank you for looking into this!

archaengel commented 10 months ago

For posterity -- setting inactive_color=00000000 is a workaround to get rid of this issue for folks still on Ventura

nicocossiom commented 10 months ago

For posterity -- setting inactive_color=00000000 is a workaround to get rid of this issue for folks still on Ventura

can confirm this does indeed fix the issue. Thank you very much, pretty clever solution