search

FelixKratz / JankyBorders

A lightweight window border system for macOS
GNU General Public License v3.0
1k stars 18 forks source link

make borders completely square if width > 2.63f and border order above #44

Closed rockofox closed 8 months ago

rockofox commented 8 months ago

Adds an option to "force" fully square borders, without any inner border radius. Works best with applications that don't have a rounded window shape (but also looks okay on others when order=above is used).

I don't know if this is really in interest for the project currently, but I just wanted to put this out for those interested.

see https://github.com/FelixKratz/JankyBorders/pull/44#issuecomment-1871755417

grafik
Spuxy commented 8 months ago

Nice ! that's what I was looking for either !

FelixKratz commented 8 months ago

I was thinking that we could make this the default behaviour if order=above and the width of the border being larger than ~2.63, then we could inset the border by 2.63/2 points and the window rounding should be guaranteed to be not visible. We would not need a separate style option with this heuristic. What do you think?

rockofox commented 8 months ago

grafik

I've implemented your suggestion, and it looks good, I think. However, I want to mention that 2.63 isn't necessarily enough of a border inset to completely hide the window rounding.

From my testing, only values around 4.f seem to conceal it completely. But 4.f is quite thick, and the "reward" for setting it to 4.f is just hiding a few ugly pixels, so...

FelixKratz commented 8 months ago

I made some similar changes on master.