FelixKratz
commented
8 months ago I have animations enabled and this issue is the reason why I made the animation duration a lot shorter than I would ideally want, so yeah it is definitely worth discussing.
There are three ways I see this could be tackled:
- Employ a heuristic on the borders side
- Employ a heuristic on the yabai side
- Employ a shared solution by utilizing the mach port of borders for yabai to send messages to.
I think it would make more sense to have a heuristic for this problem on the borders side (given the largely disproportionate user base). Maybe something (janky...) like this:
int cid = SLSMainConnectionID();
int wid_cid = 0;
SLSGetWindowOwner(cid, wid, &wid_cid);
pid_t pid = 0;
SLSConnectionGetPID(wid_cid, &pid);
static char pid_name_buffer[PROC_PIDPATHINFO_MAXSIZE];
proc_name(pid, &pid_name_buffer, sizeof(pid_name_buffer));
static int count = 0;
if (strcmp(pid_name_buffer, "yabai") == 0) {
count++;
printf("%d: Yabai Window detected: %d\n", count, wid);
CGRect frame;
SLSGetWindowBounds(cid, wid, &frame);
// Find parent window based on frame and space (maybe not robust for windows sharing origin, size and space, e.g. stacks)
CGAffineTransform transform = {0}, transform_old = {0};
for(int i = 0; i < 120; i++) {
SLSGetWindowTransform(cid, wid, &transform);
printf("%f %f %f %f %f %f\n", transform.tx, transform.ty, transform.a, transform.b, transform.c, transform.d);
if (CGAffineTransformEqualToTransform(transform, transform_old)) break;
// set the parent window border transform.
usleep(8000);
// allow some grace before stopping the polling
if (i % 12 == 11) transform_old = transform;
}
}This would need to run in a different thread and essentially polls the transform of the proxy window for a while. Determining the appropriate parent window of the proxy window is not robustly possible though (e.g. in a stack where space, origin and size are the same for multiple windows). However, after the animation finishes, the borders can be updated to the parent real location such that this should not be that big of a deal.
Ideally there would be an api where transform changes of windows can be registered to, but there seems to be no notification for that in the window notifications send by the window server.
Alternatively, the border could simply be removed for the duration of the animation by listening to window create and window destroy of proxy windows.
koekeishiya
Let me preface this by saying that I haven't given this a lot of thought, but I figured it might be something worth investigating..
Currently when using borders with yabai window animations, borders are of course updated to the new frame immediately; not following or waiting for the animation to finish. My question is, would there be a way for these tools to integrate more smoothtly, and if so what might that look like.
I don't know how big of an overlap there is between users that enable both of these features, and I guess the degree to how distracting it is, will vary as well.
Feel free to close if you personally don't think this is that big of an issue.
Edit: The most trivial version could be to hide the border for a given window (based on the window id) when an animation is about to start, and reveal it again when the animation finishes.