search

FelixKratz / JankyBorders

A lightweight window border system for macOS
GNU General Public License v3.0
860 stars 19 forks source link

Border does not follow space when a window is sticky (using yabai) #67

Closed koekeishiya closed 5 months ago

koekeishiya commented 5 months ago

Title. The border appears to remain on space 1 for me, regardless of which space I use to open the application, and I can see the border window visible on space 1 when opening mission control.

How to reproduce:

Copy e.g youtube video to clipboard.

Use following bind from skhd:

shift + cmd - m : mpv $(pbpaste)

with following rule in yabai:

yabai -m rule --add app="^mpv$" manage=off sticky=on layer=above opacity=1.0 grid=8:8:6:0:2:2

Switch to e.g space 4, and back to space 3. Open mission control, or just switch to space 1, and notice the border. Switch back to space 3 and the border is not there.

I can just use the blacklist feature to disable the border completely for mpv, so it is not a big deal.

FelixKratz commented 5 months ago

I have improved the handling of sticky windows in the code by making the border sticky as well depending on the window tag. I hope this fixes the problem.

koekeishiya commented 5 months ago

Can confirm, works fine after the latest changes.