search

FelixKratz / SketchyBar

A highly customizable macOS status bar replacement
https://felixkratz.github.io/SketchyBar/
GNU General Public License v3.0
5.63k stars 86 forks source link

Notch is off-centered #585

Open Capybara121 opened 1 month ago

Capybara121 commented 1 month ago

I'm attempting to set up a split bar design using fillers positioned at positions q and e, and am noticing that the notch appears to be off-centered. The two sides of the bar reach out to different distances away from the notch.

Screenshot 2024-07-29 at 7 16 11 PM

The left bracket measures 1267 pixels wide, while the right bracket measures 1269 pixels wide.

PhrantiK commented 1 month ago

You have notch_width defined twice in your bar config, one value with an odd number.

Capybara121 commented 1 month ago

You have notch_width defined twice in your bar config, one value with an odd number.

Thanks, didn't notice that. That being said, the issue still persists as the newest value is an even number, which should have overwritten the odd number notch. Also, the behaviour for an odd-pixel notch should be that there is a one pixel difference, right?

Screenshot 2024-08-02 at 8 46 39 PM

FelixKratz commented 1 month ago

It is probably an off-by-one error I made here: https://github.com/FelixKratz/SketchyBar/blob/c713afe574d1652eee7967ea490c6061ecca9f29/src/bar.c#L246-L250

Feel free to play with these two lines till it is symmetric and post a PR.