search

FelixKratz / dotfiles

My personal macOS configuration
GNU General Public License v3.0
929 stars 92 forks source link

Memory leak or increasing buffer in cpu.h #32

Closed gallantcrusader closed 10 months ago

gallantcrusader commented 10 months ago

might be due to underlying mach implementation in sketchybar.h, but increases by 4kb(?) every update

FelixKratz commented 10 months ago

Are you using latest commit?

gallantcrusader commented 10 months ago

Nope, sorry, please update the header in SketchyBarHelper I think they may be different, thanks!

FelixKratz commented 10 months ago

Thanks for the heads up, it should be fixed with this commit: https://github.com/FelixKratz/SketchyBarHelper/commit/bf4ff7487df295727cb1256ae92cdc257f506948 can you confirm?

gallantcrusader commented 10 months ago

Looks good, please remove the static inline from the methods: event_server_begin, env_get_value_for_key, and sketchybar because I am using Rust bindings so those methods need to be externally available please. Also I changed the int on line 210 to uint32_t to make the comparisons the same type.