search

FelixKratz / dotfiles

My personal macOS configuration
GNU General Public License v3.0
966 stars 92 forks source link

fix: Fix issues with icons #42

Closed Patrick-orz closed 7 months ago

Patrick-orz commented 7 months ago

Thank you for the great setup!

The original setup comes with overly large front app icons like this:

Screen Shot 2024-03-14 at 10 15 14 AM

I halved the icon in size for it to look more reasonable:

Screen Shot 2024-03-14 at 10 16 27 AM

icon_map.sh is also somewhat outdated, including issues such as iTerm2 missing an icon, WeChat in english missing an icon. I updated icon_map.sh to the latest sketchybar-app-font release. WeChat in English and iTerm2 missing icons before:

Screen Shot 2024-03-14 at 10 43 16 AM

After:

Screen Shot 2024-03-14 at 10 44 17 AM

Sorry about my different indentation style.

FelixKratz commented 7 months ago

I posted my completely reworked config today where this should be fixed.

Patrick-orz commented 7 months ago

I just got the newest version up and running! I see that front app icons are removed entirely, but I don't think the second issue is solved. /helpers/app_icons.lua is still outdated, with the previously explained problem still prominent.