support CSS inlining - Githubissues

FelixSchwarz / mjml-python

Python implementation for MJML - a framework that makes responsive-email easy

MIT License

74 stars 16 forks source link

support CSS inlining #1

Closed FelixSchwarz closed 2 years ago

FelixSchwarz commented 3 years ago

It would be nice to support CSS inlining (similar to mjml upstream). There are some Python libraries which might be helpful:

premailer, 3-clause BSD, recent commits
inlinestyler, 3-clause BSD, last commit March 2018
pynliner, MIT license, last commit January 2017

Based on the number of github stars, forks I guess premailer seems to be the most popular library.

caseyjhol commented 2 years ago

https://github.com/Stranger6667/css-inline/tree/master/bindings/python seems promising.

FelixSchwarz commented 2 years ago

Closed via 611f7f013aea15147916117242593b59b3153ef8 and cc1b3447c69bd20dd98a3d741d2bdf8ee1c631c5.

We can also support other css inlining libraries in the future if someone wants to add support for that. In particular I could imagine having a pure-python implementation could be nice. However "css_inline" looks ok for now so I won't add support for premailer in the near tearm.