search

FelixSchwarz / mjml-python

Python implementation for MJML - a framework that makes responsive-email easy
MIT License
73 stars 16 forks source link

adds support for HTML5 entities #11

Closed barsch closed 3 years ago

barsch commented 3 years ago

proposed fix for issue #6

barsch commented 3 years ago

hmm seems like pypy doesn't like this solution

There is also the problem with & in links, e.g.

<mj-text>
  <a href="https://www.google.de/search?q=mjml&oq=mjml">blah</a>
<mj-text>

which will fail ...

I'm really annoyed atm with lxml - we need a XML-like parser which just ignores entities altogether and is less strict ... any ideas?

barsch commented 3 years ago

closing for now

FelixSchwarz commented 3 years ago

hmm seems like pypy doesn't like this solution

If that was the only problem I'd say we just remove pypy. I like enabling it by default but I only have very few projects which actually run pypy in production (and none of these is using mjml).

I'm really annoyed atm with lxml - we need a XML-like parser which just ignores entities altogether and is less strict ... any ideas?

Not sure if I remember everything correctly but maybe Python's html.parser could fit the bill as well?