search

FelixSchwarz / mjml-python

Python implementation for MJML - a framework that makes responsive-email easy
MIT License
72 stars 16 forks source link

add support for json-like dict as input #13

Closed pcorpet closed 3 years ago

pcorpet commented 3 years ago

For #12

FelixSchwarz commented 3 years ago

Thank you for your contribution.

Some comments about the code:

  1. I removed a leftover comment (commit a34dc8b5ae10d0e2a7240690e57e24312bd62498)
  2. I think the list comprehensions were much too big. I think readability is much better when using traditional for-loops (commit e1c006e213f26fb6dd9cf406b6e7b849350f6bc7).
  3. Not sure if I like the type annotations (function signature is much harder to read imho). I just left them but I'm not really keen on expanding the use inside this library.
  4. One question related to hiding children: https://github.com/FelixSchwarz/mjml-stub/commit/e1c006e213f26fb6dd9cf406b6e7b849350f6bc7#r47802651