search

FelixSchwarz / mjml-python

Python implementation for MJML - a framework that makes responsive-email easy
MIT License
78 stars 16 forks source link

Cannot add padding to mj-column inside mj-attributes #18

Closed mrcoles closed 2 years ago

mrcoles commented 2 years ago

I believe this is a bug. Setting something like this:

<mj-attributes>
  <mj-column padding="0" />
</mj-attributes>

Raises the error:

TypeError: html_args() takes 1 positional argument but 2 were given

Looks like this line should unpack the dictionary with **: https://github.com/FelixSchwarz/mjml-stub/blob/9f87b517ebd4bace7881084c353410a262da527b/mjml/elements/mj_column.py#L185

FelixSchwarz commented 2 years ago

Thank you for the minimal reproducer. I'll take a look soon.

FelixSchwarz commented 2 years ago

fixed in main branch :-)