search

FelixSchwarz / mjml-python

Python implementation for MJML - a framework that makes responsive-email easy
MIT License
73 stars 16 forks source link

Broken compability with newer versions of css_inline library #43

Closed ididit4you closed 8 months ago

ididit4you commented 10 months ago

Hi @FelixSchwarz! There was broken changes in css_inline after v0.9.0 interface was changed and now it does not allow inline_style_tags attribute.

Last working v0.9.0 New v0.10.0

Possible solutions:

  1. Set fixed version in setup.cfg to the v0.9.0
  2. Support the new css_inline.CSSInliner interface end test how it works
FelixSchwarz commented 10 months ago

Thank you for the report. I'll look into that. I think this was also brought up in #42. Should be a big thing to handle (ideally old + new API ?).

FelixSchwarz commented 10 months ago

Unfortunately the inline_style_tags option was removed without an obvious replacement so for now I released mjml-python v0.9.1 which pins the dependency to the old version.

I just noticed that @caseyjhol already filed an issue upstream and the upstream author agreed to reinstante the parameter.

caseyjhol commented 10 months ago

I'm working on a PR that will pin the css-inline version (but I've been waiting for the latest version with the fix to come out first). I've also discovered another CSS issue related to child selectors that I'll be pushing up a fix for.

caseyjhol commented 10 months ago

If we want to pin to an old version, we'll need to pin to 0.8.7 as 0.9.0 has been yanked.

Stranger6667 commented 10 months ago

FYI, I am working on a PR that re-introduces the inline_style_tags option with the same behavior as before.

Stranger6667 commented 10 months ago

The inline_style_tags option is reintroduced in css-inline==0.11.0