search

Fellow93 / RealisticBattleProject

Source files of Realistic Battle mod for Mount and Blade 2 Bannerlord
27 stars 14 forks source link

Fixed Bugs in the crafting pieces XML files caused by old data (updated with data from Bannerlord 1.2.8) #9

Closed Healerbob closed 8 months ago

Healerbob commented 9 months ago

All XML files containing changes to crafting pieces were sorted to match the vanilla files and formatted with notepad++ (pretty print - indented attributes) to make file comparison possible. Afterwards all changes to names, piece_offsets and attributes were forwarded from vanilla to the RBM files. The piece_offsets of all Polearms and throwing axes and other intentional changes were not copied from vanilla. Civilian flags and CanHook flags were not changed either, since I don't know if these are deliberatly changed in RBM or not.

The individual commits are structured, so that all changes should be obvious when looking at the details of each commit.

Healerbob commented 9 months ago

After some in game testing I reverted all changes to the axe crafting parts.

I also noticed that combining the "menavliton head" or "swordstaff" pieces with the "wooden two handed grip" in the two handed polearm category during smithing causes an error. The game works just fine if you continue after the error message (BLSE/BEW), so it probably isn't game breaking, but it's ugly

Healerbob commented 9 months ago

I did some digging and managed to fix the issues with those two spearheads. They didn't have an entry in the weapons description file. Thanks to this I also noticed that those descriptions need to be updated as well.

Healerbob commented 9 months ago

Added some additional fixes. All the crafting pieces are now done and any additional changes (armor etc.) will be done in a separate branch and a new pull request. (I don't want to just dump everything into this one, so it doesn't take too long to look at everything)