Felx-B / vscode-web

Visual Studio Code for browser
MIT License
397 stars 105 forks source link

Register FileSystemHandle metadata for common text/code files #7

Closed FossPrime closed 2 years ago

FossPrime commented 2 years ago

Example of what it looks like with the Excalidraw PWA (This is in no way a native App, this was installed by chrome from the URL): Screenshot 2022-02-03 16 37 04

Felx-B commented 2 years ago

I don't really understand the question here. But I think what your are looking for is to use vscode-web as a local file editor.

Now VSCode have those features built-in

Open a local file

Open a local folder

FossPrime commented 2 years ago

Currently when I want to edit a JSON, csv, md or js file I just downloaded, If I right click on it in the file manager, vscode-web doesn't show up as an option, despite being installed. There is now an API to make it show up... XCalidraw uses it and I've attached a screenshot of their use in the OP

Here's what it currently looks like when I right click a json file in my file manager, notice the absence of vscode-web:

Screenshot 2022-02-03 16 35 25

This also allows setting vscode-web as the default file handler, which can make opening a csv or txt report go from a 5 click process, down to a single click process.

hello-smile6 commented 2 years ago

Currently when I want to edit a JSON, csv, md or js file I just downloaded, If I right click on it in the file manager, vscode-web doesn't show up as an option, despite being installed. There is now an API to make it show up... XCalidraw uses it and I've attached a screenshot of their use in the OP

Here's what it currently looks like when I right click a json file in my file manager, notice the absence of vscode-web:

Screenshot 2022-02-03 16 35 25

This also allows setting vscode-web as the default file handler, which can make opening a csv or txt report go from a 5 click process, down to a single click process.

@rayfoss Think this would be an issue better suited for microsoft/vscode

FossPrime commented 2 years ago

VSCode is distributed as a native app, they have no need to implement new web APIs... specially as this is most useful for non-DOS based operating systems like M1 Macs and web based OSs popular in schools.

Would you consider a PR that registers vscode-web as a csv, txt and html app with FileSystemHandle?

hello-smile6 commented 2 years ago

VSCode is distributed as a native app, they have no need to implement new web APIs... specially as this is most useful for non-DOS based operating systems like M1 Macs and web based OSs popular in schools.

Would you consider a PR that registers vscode-web as a csv, txt and html app with FileSystemHandle?

They have a web app! Also, they have an app for M1 macs! DO YOUR RESEARCH!

FossPrime commented 2 years ago

I'm going to have to find that web-app... this is the repo I landed on while searching for that web app. Their M1 mac app is based on electron... meaning it's not as battery optimized for the M1 as a Safari backed PWA. ...

Update: I thought this was the code used to generate VSCode Web ...