search

FemeniasM / ExplorATE_shell_script

6 stars 3 forks source link

typos in .sh scripts #3

Closed RAWWiberg closed 1 year ago

RAWWiberg commented 1 year ago

Hello again,

I spotted some typos in the .sh scripts in the bin/ folder that were causing some errors.

Specifically, when assigning the salmon_path variable, there was an extra "=" character which meant bash could not find the salmon command (because it was looking for "=salmon" instead of "salmon".

I took the liberty of forking your repo and fixing this. I've made a pull request for you.

Best wishes,

FemeniasM commented 1 year ago

Dear @RAWWiberg I checked your edits, I really appreciate your help! I've been quite busy in the last few months, but I hope to improve the code over time and make it as useful as possible for users. Your contribution will certainly always be welcome, best regards

RAWWiberg commented 1 year ago

Hello,

No problem at all. I really like the idea of ExplorATE so I wanted to give it a try immediately. And it's rare that I find an issue that I can help fix, so I am very glad to be able to help.

Looking forward to seeing how ExplorATE develops :)

Best wishes, Axel ------- Original Message ------- On Thursday, December 8th, 2022 at 19:04, FemeniasM @.***> wrote:

Dear @.***(https://github.com/RAWWiberg) I checked your edits, I really appreciate your help! I've been quite busy in the last few months, but I hope to improve the code over time and make it as useful as possible for users. Your contribution will certainly always be welcome, best regards

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>