search

FemtoEmacs / Femto-Emacs

Tiny emacs clone with configuring in FemtoLisp
114 stars 14 forks source link

Discarding changes on an file open twice in split buffers crashes Femto-Emacs #10

Open siraben opened 6 years ago

siraben commented 6 years ago

Reproducing the following steps produces a segfault

  1. Open a file in Femto-Emacs (e.g. main.c)
  2. Split the buffer with C-x 2, the file should now be open in two buffers
  3. Make a change
  4. Kill the buffer with C-x k and answering y
  5. Move to the other buffer with C-x o
  6. C-x k and answering y produces the segfault.

What's interesting is that doing step 6 but answering n does not crash Femto-Emacs.

hughbarney commented 6 years ago

Agreed this is a bug. fix is fairly simple. What is happening is that the code is not checking if any other window has a reference to the buffer that is being killed in the current window. It is probably about a 10 line fix. Will fix in the Femto repository when I get time. https://github.com/hughbarney/femto