search

FenTechSolutions / CausalDiscoveryToolbox

Package for causal inference in graphs and in the pairwise settings. Tools for graph structure recovery and dependencies are included.
https://fentechsolutions.github.io/CausalDiscoveryToolbox/html/index.html
MIT License
1.13k stars 199 forks source link

SID_CPDAG does not automatically converts a DAG to CPDAG #108

Open xwshen51 opened 3 years ago

xwshen51 commented 3 years ago

In cdt.metrics.SID_CPDAG, the prediction is not converted to a CPDAG. Currently one needs to convert a DAG to a CPDAG before inputting it to the function.

It may be better to add predictions = get_CPDAG(predictions) as done in SHD_CPDAG.

Thanks for your great contribution!

diviyank commented 3 years ago

Hello ! Whoops ! Yes we should do this step before, thanks for the feedback !