search

FenTechSolutions / CausalDiscoveryToolbox

Package for causal inference in graphs and in the pairwise settings. Tools for graph structure recovery and dependencies are included.
https://fentechsolutions.github.io/CausalDiscoveryToolbox/html/index.html
MIT License
1.08k stars 198 forks source link

GIES targets and target.index parameter needs to be exposed #145

Open shahashka opened 1 year ago

shahashka commented 1 year ago

The cdt.causality.graph.GIES constructor is missing parameters to set the targets and target.index parameters for the score functions GaussL0penIntScore and GaussL0penObsScore. These parameters allow the user to specify the interventional targets and which data row has which intervention applied -- this is needed for the GIES algorithm. See https://search.r-project.org/CRAN/refmans/pcalg/html/GaussL0penIntScore-class.html

As is, the gies.R code uses source$getTargets() which by default sets targets to observational targets only. This means right now, the GIES algorithm in cdt does not handle interventional data properly.

diviyank commented 1 year ago

Hello ! Yes I forgot about this ! It's in the roadmap and I need to update this.

Thank you, noted. Best, Diviyan

shahashka commented 1 year ago

Ok cool! Patiently will wait for this update :) (Do you have an approximate timeline?) Thanks for the reply